refactor: Make ViewAccessControl more extensible #13674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
flow-server/src/main/java/com/vaadin/flow/server/auth/ViewAccessChecker.java
Show resolved
Hide resolved
Artur-
force-pushed
the
open-viewaccesscontrol
branch
from
d6ac48d to
60183cb
Compare
Makes it possible to fetch the principal and roles from other sources than the HTTP request
Artur-
force-pushed
the
open-viewaccesscontrol
branch
from
60183cb to
68b1be6
Compare
flow-server/src/main/java/com/vaadin/flow/server/auth/ViewAccessChecker.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
flow-server/src/main/java/com/vaadin/flow/server/auth/ViewAccessChecker.java
Show resolved
Hide resolved
mshabarov
reviewed
May 11, 2022
flow-server/src/test/java/com/vaadin/flow/server/auth/ViewAccessCheckerTest.java
Show resolved
Hide resolved
mshabarov
approved these changes
May 11, 2022
flow-server/src/test/java/com/vaadin/flow/server/auth/ViewAccessCheckerTest.java
Show resolved
Hide resolved
vaadin-bot
pushed a commit
that referenced
this pull request
May 12, 2022
Makes it possible to fetch the principal and roles from other sources than the HTTP request.
mshabarov
pushed a commit
that referenced
this pull request
May 12, 2022
Makes it possible to fetch the principal and roles from other sources than the HTTP request. Co-authored-by: Artur <[email protected]>
mshabarov
pushed a commit
that referenced
this pull request
May 12, 2022
…13675) (#13754) Requires the spring context to be properly set up for the background thread. Based on #13674 Co-authored-by: Artur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to fetch the principal and roles from other sources than the HTTP request